Skip to content

fix: Consider transient overlay windows when respectSystemAlerts is enabled#946

Merged
mykola-mokhnach merged 6 commits intoappium:masterfrom
mwakizaka:fix/respect_half_modals
Oct 17, 2024
Merged

fix: Consider transient overlay windows when respectSystemAlerts is enabled#946
mykola-mokhnach merged 6 commits intoappium:masterfrom
mwakizaka:fix/respect_half_modals

Conversation

@mwakizaka
Copy link
Copy Markdown

@mwakizaka mwakizaka commented Oct 16, 2024

The problem

  • I've found that WDA v6.0.0 or later fails to find elements on a half modal like below.
  • Just fyi, let me share the source trees (XCUIElementTypeWindow type="XCUIElementTypeWindow" name="SBTransientOverlayWindow" no longer appears in app-source-WDA_6.0.0.txt)

The proposed change

What I confirmed

  • Before: Cannot find an element using accessibility id=Sandbox
  • After: Can find an element using accessibility id=Sandbox after update {"respectSystemAlerts":true} setting
  • The appium.log

Comment thread WebDriverAgentLib/Routing/FBSession.m Outdated
Comment thread WebDriverAgentLib/Routing/FBSession.m Outdated
@mwakizaka mwakizaka force-pushed the fix/respect_half_modals branch from dc629c3 to 00c4fa8 Compare October 16, 2024 10:22
Comment thread WebDriverAgentLib/Routing/FBSession.m Outdated
@mwakizaka mwakizaka changed the title feat: Add a setting to respect half modals while detecting active apps fix: Consider transient overlay windows when respectSystemAlerts is enabled Oct 16, 2024
@KazuCocoa
Copy link
Copy Markdown
Member

KazuCocoa commented Oct 17, 2024

hm, GHA's macOS instances are taking longer time

Comment thread WebDriverAgentLib/Routing/FBSession.m Outdated
Comment thread WebDriverAgentLib/Routing/FBSession.m Outdated
@mykola-mokhnach mykola-mokhnach merged commit f0bdce7 into appium:master Oct 17, 2024
github-actions Bot pushed a commit that referenced this pull request Oct 17, 2024
## [8.9.4](v8.9.3...v8.9.4) (2024-10-17)

### Bug Fixes

* Consider transient overlay windows when respectSystemAlerts is enabled ([#946](#946)) ([f0bdce7](f0bdce7))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 8.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jlipps
Copy link
Copy Markdown
Member

jlipps commented Nov 7, 2024

Hi @mwakizaka, congrats, the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you!

@mwakizaka
Copy link
Copy Markdown
Author

Hi @jlipps, thank you for your offer! Please use https://opencollective.com/masayuki-wakizaka

manabuaota added a commit to manabuaota/airtest-netease that referenced this pull request Feb 14, 2026
## [8.9.4](appium/WebDriverAgent@v8.9.3...v8.9.4) (2024-10-17)

### Bug Fixes

* Consider transient overlay windows when respectSystemAlerts is enabled ([#946](appium/WebDriverAgent#946)) ([f0bdce7](appium/WebDriverAgent@f0bdce7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size:S contribution size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants