Skip to content

feat: remove nodeify* functions as obsolete#52

Merged
eglitise merged 1 commit intoappium:masterfrom
eglitise:rm-nodeify
Jan 20, 2026
Merged

feat: remove nodeify* functions as obsolete#52
eglitise merged 1 commit intoappium:masterfrom
eglitise:rm-nodeify

Conversation

@eglitise
Copy link
Copy Markdown
Contributor

BREAKING CHANGE: remove nodeify and nodeifyAll functions as obsolete

These functions are only useful in ES5 projects, and the Appium ecosystem only supports Node 20 and above. I don't think they are needed anymore, and I could not find any uses of either, GitHub-wide.

Another reason why I would like to remove them is that nodeify calls Bluebird's nodeify(). I would like to migrate away from Bluebird, but Node does not have equivalent functionality, so it must be reimplemented manually - or simply removed.

@eglitise eglitise merged commit b50a289 into appium:master Jan 20, 2026
6 checks passed
@eglitise eglitise deleted the rm-nodeify branch January 20, 2026 17:51
github-actions bot pushed a commit that referenced this pull request Jan 20, 2026
## [4.1.0](v4.0.2...v4.1.0) (2026-01-20)

### Features

* remove nodeify* functions as obsolete ([#52](#52)) ([b50a289](b50a289))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

eglitise added a commit that referenced this pull request Jan 20, 2026
eglitise added a commit that referenced this pull request Jan 20, 2026
github-actions bot pushed a commit that referenced this pull request Jan 20, 2026
## [4.1.1](v4.1.0...v4.1.1) (2026-01-20)

### Bug Fixes

* revert "feat: remove nodeify* functions as obsolete ([#52](#52))" ([#53](#53)) ([cf19ced](cf19ced))
@eglitise eglitise restored the rm-nodeify branch January 20, 2026 18:02
@eglitise eglitise deleted the rm-nodeify branch January 20, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants