test: adjust reduced interval check for waitForCondition#56
Merged
eglitise merged 1 commit intoappium:masterfrom Jan 21, 2026
Merged
test: adjust reduced interval check for waitForCondition#56eglitise merged 1 commit intoappium:masterfrom
waitForCondition#56eglitise merged 1 commit intoappium:masterfrom
Conversation
mykola-mokhnach
approved these changes
Jan 21, 2026
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing test
should not exceed implicit wait timeoutdoes not seem to be very useful:waitMsis set to twice the value ofintervalMs, which in some cases may result in the secondsleepcall not reducingintervalMsat all, meaning the test does not actually validate its functionality at all times.I have now updated the test in two ways:
waitMsis set to a value that is not a multiple ofintervalMs, thereby ensuring that the lastsleepcall will always be invoked with a reduced value ofintervalMssleepand validating its last call, the test now checks that the total elapsed time is always belowceil(waitMs/intervalMs). This makes the spy variable obsolete and allows to removesinonas a whole.