Skip to content

#160 fix #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jonahss merged 3 commits into from
Mar 11, 2015
Merged

#160 fix #163

Jonahss merged 3 commits into from
Mar 11, 2015

Conversation

@TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Mar 6, 2015

Change list:

  • Enum SwipeElementDirection is redesigned. The ability to perform the swiping was with offset was added.
  • The swiping using offset from element borders was added to MobileElement.

@TikhomirovSergey
#160 Enum SwipeElementDirection is redesigned.
0dc816c 
I have to redesign coordinate calculation and add the new swipe-method
to MobileElement.
@TikhomirovSergey
#160 is fixed
166a0cb
@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Mar 6, 2015

#160

Jonahss
Jonahss reviewed Mar 9, 2015
View reviewed changes
src/main/java/io/appium/java_client/TouchableElement.java Outdated
Copy link
Member

@Jonahss Jonahss Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between offset1 and offset2? Do you mean to say that offset1 is offset from the element that swipe starts on, and offset2 is from the element that the swipe ends on?

Copy link
Contributor Author

@TikhomirovSergey TikhomirovSergey Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offset1 and offset2 are offsets from borders of the element.
offset1 is the offset from the border where the swiping should be started.
offset2 is the offset from the border where the swiping should be ended.
If parameter names are not clear how should I rename them?

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Mar 9, 2015

Ok. I am going to rename offset1 and offset2 to offsetFromStartBorder and offsetFromEndBorder. Is it ok?

@Fanch-
Copy link

Fanch- commented Mar 10, 2015

For me it's clear.

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Mar 10, 2015

Ok.

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Mar 10, 2015

I've improved parameter names and comments.

@Jonahss
Copy link
Member

Jonahss commented Mar 11, 2015

Great :)

Jonahss added a commit that referenced this pull request Mar 11, 2015
@Jonahss
Merge pull request #163 from TikhomirovSergey/swipeEnhancement
ce2ca86 
#160 fix
@Jonahss Jonahss merged commit ce2ca86 into appium:master Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TikhomirovSergey @Fanch- @Jonahss