Skip to content

Conversation

@coding-yogi
Copy link
Contributor

No description provided.

@coding-yogi coding-yogi changed the title Fix for issue 208 and 219 Fix for issue #208 and #219 Sep 3, 2015
@ghost
Copy link

ghost commented Sep 10, 2015

Would it be possible for someone to review this, and get it merged? Thanks!

@TikhomirovSergey
Copy link
Contributor

Hi @aniket-21
I can't make a decision. Let's wait for @Jonahss

Now your changes are in conflict with the master. The conflicted code:https://github.com/appium/java-client/pull/233/files#diff-c60f84c0cc90f37a9a4513eeebd4896dR214

The command map filling has been moved here:
https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/AppiumDriver.java#L666

Can you resolve this conflict?

@coding-yogi
Copy link
Contributor Author

Yes, I can resolve the conflict. ImmutableMap builder has just been moved under the getMobileCommands()

@TikhomirovSergey let me know if you would be able to handle this during merge else I will create a new pull request

@coding-yogi
Copy link
Contributor Author

@TikhomirovSergey can you take a look now?

@TikhomirovSergey
Copy link
Contributor

Yep. As for me it is ok. But the communicatin with the server / low level features and the release publishing are not my area for now.

@Jonahss
Copy link
Member

Jonahss commented Sep 14, 2015

Looks great. Those two issues have been pending for a while, thanks very much for clearing them up.

Jonahss added a commit that referenced this pull request Sep 14, 2015
@Jonahss Jonahss merged commit 3f7c44a into appium:master Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants