Skip to content

Conversation

@SrinivasanTarget
Copy link
Member

Change list

As we discussed,I have formatted our repo based on Google Java Style Guide

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

@TikhomirovSergey As we discussed, i have formatted our code based on Google Style Guide. Please review. I've reviewed it from my side changes conforms Google style, https://google.github.io/styleguide/javaguide.html

Looking forward to hear from you:)

@SrinivasanTarget SrinivasanTarget changed the title Formatting code w.r.t Google Java Style Guide #269 Formatting code w.r.t Google Java Style Guide Mar 26, 2016
@SrinivasanTarget SrinivasanTarget changed the title Formatting code w.r.t Google Java Style Guide Formatted code w.r.t Google Java Style Guide Mar 26, 2016
@TikhomirovSergey
Copy link
Contributor

@SrinivasanTarget
Ok. But there are some remarks.

  1. https://github.com/appium/java-client/pull/346/files#diff-600376dffeb79835ede4a0b285078036R217
    Please update to the latest version. http://mvnrepository.com/artifact/org.apache.maven.plugins/maven-eclipse-plugin
  2. Can you provide steps or links which describe things that conpributors should do (especially IDEA users)?

@SrinivasanTarget
Copy link
Member Author

Have updated the code standards here, https://github.com/appium/java-client/wiki/Note-for-developers.

Please review and let me know for any corrections.

@TikhomirovSergey TikhomirovSergey merged commit 353e1d2 into appium:master Mar 28, 2016
@SrinivasanTarget SrinivasanTarget mentioned this pull request Apr 6, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants