Skip to content

Conversation

@SrinivasanTarget
Copy link
Member

Change list

Checkstyle validation to ensure google java code style is followed or not

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Continuation of #346

@TikhomirovSergey @Jonahss @bootstraponline Please take a look at this PR :)

@SrinivasanTarget
Copy link
Member Author

We can perform checks through maven going forward from CI.
https://maven.apache.org/plugins/maven-checkstyle-plugin/plugin-info.html

@SrinivasanTarget
Copy link
Member Author

Great to see our repo audit reports shows there are "0" errors and "7774" warnings that we can work out.

@SrinivasanTarget
Copy link
Member Author

screen shot 2016-04-07 at 12 14 07 am

@TikhomirovSergey
Copy link
Contributor

@SrinivasanTarget
I like this PR 👍
But I a little but modified it. My modification is here: https://github.com/TikhomirovSergey/java-client/blob/SrinivasanTarget-master/pom.xml

I'm going to merge this PR with my own modification after source code improvement.

@bootstraponline What do you think about this? I think it is much better solution than proposed here:
#269. The idea: CI build should be failed on code style violation. All this thing are going to be documented in details. Now we have the description how to set up the requrd code style settings: https://github.com/appium/java-client/blob/master/docs/Note-for-developers.md

@SrinivasanTarget
Copy link
Member Author

I like your modification @TikhomirovSergey 👍

@TikhomirovSergey TikhomirovSergey added this to the 4.0.0 milestone Apr 8, 2016
@SrinivasanTarget
Copy link
Member Author

@TikhomirovSergey Added goals as per your comments :)

@SrinivasanTarget
Copy link
Member Author

👍

@SrinivasanTarget
Copy link
Member Author

@SrinivasanTarget
Copy link
Member Author

Thanks for adding me:)

@TikhomirovSergey TikhomirovSergey mentioned this pull request Apr 17, 2016
3 tasks
@bootstraponline
Copy link
Member

CI build should be failed on code style violation

👍

@TikhomirovSergey TikhomirovSergey merged commit 31ba103 into appium:master Apr 18, 2016
TikhomirovSergey added a commit that referenced this pull request Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants