The addition to the PR #354

README.md

@@ -112,7 +112,20 @@ If you are using the Eclipse IDE, make sure you are using version Luna or later.
 ##Changelog##
 *4.0.0 (under construction yet)*
 - FIX of TouchAction. Instances of the TouchAction class are reusable now
-- FIX of the swiping issue (iOS, server version >= 1.5.0). Now the swiping is implemented differently by AndroidDriver and IOSDriver. Thanks to [@truebit](https://github.com/truebit) and [@nuggit32](https://github.com/nuggit32) for the catching.
+- FIX of the swiping issue (iOS, server version >= 1.5.0). Now the swiping is implemented differently by 
+AndroidDriver and IOSDriver. Thanks to [@truebit](https://github.com/truebit) and [@nuggit32](https://github.com/nuggit32) for the catching.
+- the project was integrated with [maven-checkstyle-plugin](https://maven.apache.org/plugins/maven-checkstyle-plugin/). Thanks to [@SrinivasanTarget](https://github.com/SrinivasanTarget) for the work
+- all code marked `@Deprecated` was removed. Java client won't support old servers (v<1.5.0)
+anymore.
+- source code was improved according to code style checking rules. 
+- The refactoring of `io.appium.java_client.internal.JsonToMobileElementConverter`. Now it accepts 
+`org.openqa.selenium.remote.RemoteWebDriver` as the constructor parameter. It is possible to re-use 
+`io.appium.java_client.android.internal.JsonToAndroidElementConverter` or 
+`io.appium.java_client.ios.internal.JsonToIOSElementConverter` by RemoteWebDriver when it is needed.
+- Constructors of the abstract `io.appium.java_client.AppiumDriver` were redesigned. Now they require 
+a subclass of `io.appium.java_client.internal.JsonToMobileElementConverter`. Constructors of 
+`io.appium.java_client.android.AndroidDriver` and `io.appium.java_client.ios.IOSDriver` are same still.
+
 ...
 
 *3.4.1*

docs/Note-for-developers.md

@@ -1,4 +1,4 @@
-### IDE
+# IDE
 
 If you are working on this project and use Intellij Idea, you need to change the compiler to the Eclipse compiler instead of the default javac. 
 
@@ -7,7 +7,7 @@ If you are working on this project and use Intellij Idea, you need to change the
 
 If you are using the Eclipse IDE, make sure you are using version Luna or later.
 
-### Coding Standards
+# Coding Standards
 
 Appium java-client strictly follows [Google Java Style](http://google-styleguide.googlecode.com/svn/trunk/javaguide.html) as a coding standards. Contributors are requested to follow this by configuring in their IDE's Editor Code style,
 
@@ -20,3 +20,30 @@ Appium java-client strictly follows [Google Java Style](http://google-styleguide
 `Preferences -> Java -> Code Style -> Formatter -> Import -> eclipse-java-google-style.xml (Downloaded from Google Style Guide)-> Apply`
 
 Reformat your code before raising a Pull Request.
+
+# Code style
+
+Please be careful with code style.
+
+## How to check the style of proposed code.
+
+Execute the command
+
+`mvn clean site`
+
+After the finishing please go and open
+
+`{project__folder}/target/site/index.html`
+
+and then
+
+![](https://cloud.githubusercontent.com/assets/4927589/14588981/d9eef6f6-04df-11e6-9c6f-9bbd2bed3400.png)
+
+and then
+
+![](https://cloud.githubusercontent.com/assets/4927589/14588999/29ca76e6-04e0-11e6-8647-d868ab185682.png)
+
+choose the `Checkstyle`. If there are errors please fix them. Please keep the count of warnings as minimal as 
+it possible.
+
+![](https://cloud.githubusercontent.com/assets/4927589/14589025/e817bed8-04e0-11e6-9eb9-8987f24672e0.png)

docs/The-starting-of-an-app-using-Appium-node-server-started-programmatically.md

@@ -213,35 +213,63 @@ new AndroidDriver<>(service.getUrl(), clientCapabilities);
 
 # How to create an AppiumDriver instance
 
-The list of constructors is below. All constructors are declared by [AppiumDriver](http://appium.github.io/java-client/io/appium/java_client/AppiumDriver.html) subclasses. Many of them use [AppiumDriverLocalService](http://appium.github.io/java-client/io/appium/java_client/service/local/AppiumDriverLocalService.html) or [AppiumServiceBuilder](http://appium.github.io/java-client/io/appium/java_client/service/local/AppiumServiceBuilder.html) as parameters.
+Many constructors of [AndroidDriver](http://appium.github.io/java-client/io/appium/java_client/android/AndroidDriver.html)/[IOSDriver](http://appium.github.io/java-client/io/appium/java_client/ios/IOSDriver.html) use [AppiumDriverLocalService](http://appium.github.io/java-client/io/appium/java_client/service/local/AppiumDriverLocalService.html) or [AppiumServiceBuilder](http://appium.github.io/java-client/io/appium/java_client/service/local/AppiumServiceBuilder.html) as parameters.
+The list of constructors is below.
 
+```java
+public AndroidDriver(URL remoteAddress,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(URL remoteAddress,
+            org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(AppiumDriverLocalService service,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(AppiumDriverLocalService service,
+            org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(AppiumServiceBuilder builder,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(AppiumServiceBuilder builder,
+            org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
+            org.openqa.selenium.Capabilities desiredCapabilities)
+
+public AndroidDriver(org.openqa.selenium.Capabilities desiredCapabilities)
+``` 
 
 ```java
-public AppiumDriver(URL remoteAddress,
+public IOSDriver(URL remoteAddress,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(URL remoteAddress,
+public IOSDriver(URL remoteAddress,
             org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(AppiumDriverLocalService service,
+public IOSDriver(AppiumDriverLocalService service,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(AppiumDriverLocalService service,
+public IOSDriver(AppiumDriverLocalService service,
             org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(AppiumServiceBuilder builder,
+public IOSDriver(AppiumServiceBuilder builder,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(AppiumServiceBuilder builder,
+public IOSDriver(AppiumServiceBuilder builder,
             org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
+public IOSDriver(org.openqa.selenium.remote.http.HttpClient.Factory httpClientFactory,
             org.openqa.selenium.Capabilities desiredCapabilities)
 
-public AppiumDriver(org.openqa.selenium.Capabilities desiredCapabilities)
+public IOSDriver(org.openqa.selenium.Capabilities desiredCapabilities)
 ``` 
 
 An instance of __AppiumDriverLocalService__ which has passed through constructors will be stopped when

google-style.xml

@@ -0,0 +1,219 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+
+<!-- Originally designed by:-->
+<!--
+    Checkstyle configuration that checks the Google coding conventions from Google Java Style
+    that can be found at https://google.github.io/styleguide/javaguide.html.
+
+    Checkstyle is very configurable. Be sure to read the documentation at
+    http://checkstyle.sf.net (or in your downloaded distribution).
+
+    To completely disable a check, just comment it out or delete it from the file.
+
+    Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov.
+ -->
+<!-- Modified by: Sergey Tikhomirov-->
+
+<module name = "Checker">
+    <property name="charset" value="UTF-8"/>
+
+    <property name="severity" value="error"/>
+
+    <property name="fileExtensions" value="java, properties, xml"/>
+    <!-- Checks for whitespace                               -->
+    <!-- See http://checkstyle.sf.net/config_whitespace.html -->
+        <module name="FileTabCharacter">
+            <property name="eachLine" value="true"/>
+        </module>
+
+    <module name="TreeWalker">
+        <module name="OuterTypeFilename"/>
+        <module name="IllegalTokenText">
+            <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
+            <property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
+            <property name="message" value="Avoid using corresponding octal or Unicode escape."/>
+        </module>
+        <module name="AvoidEscapedUnicodeCharacters">
+            <property name="allowEscapesForControlCharacters" value="true"/>
+            <property name="allowByTailComment" value="true"/>
+            <property name="allowNonPrintableEscapes" value="true"/>
+        </module>
+        <module name="LineLength">
+            <property name="max" value="100"/>
+            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+        </module>
+        <module name="AvoidStarImport">
+			<property name="severity" value="warning"/>
+		</module>
+        <module name="OneTopLevelClass"/>
+        <module name="NoLineWrap"/>
+        <module name="EmptyBlock">
+            <property name="option" value="TEXT"/>
+            <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
+        </module>
+        <module name="NeedBraces"/>
+        <module name="LeftCurly">
+            <property name="maxLineLength" value="100"/>
+        </module>
+        <module name="RightCurly"/>
+        <module name="RightCurly">
+            <property name="option" value="alone"/>
+            <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
+        </module>
+        <module name="WhitespaceAround">
+            <property name="allowEmptyConstructors" value="true"/>
+            <property name="allowEmptyMethods" value="true"/>
+            <property name="allowEmptyTypes" value="true"/>
+            <property name="allowEmptyLoops" value="true"/>
+            <message key="ws.notFollowed"
+             value="WhitespaceAround: ''{0}'' is not followed by whitespace. Empty blocks may only be represented as '{}' when not part of a multi-block statement (4.1.3)"/>
+             <message key="ws.notPreceded"
+             value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
+        </module>
+        <module name="OneStatementPerLine"/>
+        <module name="MultipleVariableDeclarations"/>
+        <module name="ArrayTypeStyle"/>
+        <module name="MissingSwitchDefault"/>
+        <module name="FallThrough"/>
+        <module name="UpperEll"/>
+        <module name="ModifierOrder"/>
+        <module name="EmptyLineSeparator">
+            <property name="allowNoEmptyLineBetweenFields" value="true"/>
+        </module>
+        <module name="SeparatorWrap">
+            <property name="tokens" value="DOT"/>
+            <property name="option" value="nl"/>
+        </module>
+        <module name="SeparatorWrap">
+            <property name="tokens" value="COMMA"/>
+            <property name="option" value="EOL"/>
+        </module>
+        <module name="PackageName">
+            <property name="format" value="^[a-z]||[_]+(\.[a-z][a-z0-9]*)*$"/>
+            <message key="name.invalidPattern"
+             value="Package name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="TypeName">
+			<property name="format" value="^([iOSFindBys]||[iOSFindBy]||[iOSFindAll])||([A-Z][a-zA-Z0-9])*$"/>
+            <message key="name.invalidPattern"
+             value="Type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="MemberName">
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <message key="name.invalidPattern"
+             value="Member name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="ParameterName">
+            <property name="format" value="^([a-z]||[a-z0-9]||[a-zA-Z0-9])*$"/>
+            <message key="name.invalidPattern"
+             value="Parameter name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="CatchParameterName">
+            <property name="format" value="^(([a-z])||([a-z][a-z0-9][a-zA-Z0-9]))*$"/>
+            <message key="name.invalidPattern"
+             value="Catch parameter name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="LocalVariableName">
+            <property name="tokens" value="VARIABLE_DEF"/>
+            <property name="format" value="^([a-z]||[a-z0-9]||[a-zA-Z0-9])*$"/>
+            <property name="allowOneCharVarInForLoop" value="true"/>
+            <message key="name.invalidPattern"
+             value="Local variable name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="ClassTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+             value="Class type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="MethodTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+             value="Method type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="InterfaceTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+             value="Interface type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="GenericWhitespace">
+            <message key="ws.followed"
+             value="GenericWhitespace ''{0}'' is followed by whitespace."/>
+             <message key="ws.preceded"
+             value="GenericWhitespace ''{0}'' is preceded with whitespace."/>
+             <message key="ws.illegalFollow"
+             value="GenericWhitespace ''{0}'' should followed by whitespace."/>
+             <message key="ws.notPreceded"
+             value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
+        </module>
+        <module name="Indentation">
+            <property name="basicOffset" value="4"/>
+            <property name="braceAdjustment" value="0"/>
+            <property name="caseIndent" value="4"/>
+            <property name="throwsIndent" value="4"/>
+            <property name="lineWrappingIndentation" value="4"/>
+            <property name="arrayInitIndent" value="2"/>
+        </module>
+        <module name="AbbreviationAsWordInName">
+            <property name="ignoreFinal" value="false"/>
+            <property name="allowedAbbreviationLength" value="5"/>
+        </module>
+        <module name="OverloadMethodsDeclarationOrder"/>
+        <module name="VariableDeclarationUsageDistance"/>
+        <module name="CustomImportOrder">
+            <property name="specialImportsRegExp" value="com.google"/>
+            <property name="sortImportsInGroupAlphabetically" value="true"/>
+            <property name="customImportOrderRules" value="STATIC###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE"/>
+			<property name="severity" value="warning"/>
+        </module>
+        <module name="MethodParamPad"/>
+        <module name="OperatorWrap">
+            <property name="option" value="NL"/>
+            <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
+        </module>
+        <module name="AnnotationLocation">
+            <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
+        </module>
+        <module name="AnnotationLocation">
+            <property name="tokens" value="VARIABLE_DEF"/>
+            <property name="allowSamelineMultipleAnnotations" value="true"/>
+        </module>
+        <module name="NonEmptyAtclauseDescription"/>
+        <module name="JavadocTagContinuationIndentation"/>
+        <module name="SummaryJavadoc">
+            <property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
+        </module>
+        <module name="JavadocParagraph">
+			<property name="severity" value="warning"/>
+		</module>
+        <module name="AtclauseOrder">
+            <property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
+            <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
+			<property name="severity" value="warning"/>
+        </module>
+        <module name="JavadocMethod">
+            <property name="scope" value="public"/>
+            <property name="allowMissingParamTags" value="true"/>
+            <property name="allowMissingThrowsTags" value="true"/>
+            <property name="allowMissingReturnTag" value="true"/>
+            <property name="minLineCount" value="2"/>
+            <property name="allowedAnnotations" value="Override, Test, BeforeClass, AfterClass, Before, After"/>
+            <property name="allowThrowsTagsForSubclasses" value="true"/>
+        </module>
+        <module name="MethodName">
+            <property name="format" value="^([IosUIAutomation]||[AndroidUIAutomator]||[AccessibilityId])||([a-z][a-z0-9][a-zA-Z0-9])*$"/>
+            <message key="name.invalidPattern"
+             value="Method name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="SingleLineJavadoc">
+            <property name="ignoreInlineTags" value="false"/>
+        </module>
+        <module name="EmptyCatchBlock">
+            <property name="exceptionVariableName" value="expected"/>
+
+        </module>
+        <module name="CommentsIndentation"/>
+    </module>
+</module>