The addition to the PR #354 #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification of pom.xml and google-style.xml
- cleaning of deprecated code - some source code issues were resolved
- fix of the source code issue "*should be separated from previous import group"
- checking pattern was improved - long strings, java doc endings were improved
- annotation location and order fix
- the fix of the broken starting of an activity
- static import order
- '.' should be on a new line. - methods and variables names
- "Using the '.*'" and some other issues fix
- now only method java docs need to be added
- now only method java docs need to be added #2
- missing method javadocs in test sources
- it is needed to add java docs to AndroidDriver and IOSDriver.
- all source code issues are fixed now - the refactoring of AppiumDriver constructor set - test coverage was increased - @SrinivasanTarget was added to developers section
- release notes
- release notes edition
Contributor
Author
|
@SrinivasanTarget can you review these changes @bootstraponline you can take a look at this PR if you want :) |
Member
|
I looked at the code a bit and didn't notice any issues. The PR is huge though. It'd be nice to have smaller commits so humans can understand the change history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
The addition to the PR #354
Types of changes
Details
@Deprecatedwas removed. Java client won't support old servers (v<1.5.0)anymore.
io.appium.java_client.internal.JsonToMobileElementConverter. Now it acceptsorg.openqa.selenium.remote.RemoteWebDriveras the constructor parameter. It is possible to re-useio.appium.java_client.android.internal.JsonToAndroidElementConverterorio.appium.java_client.ios.internal.JsonToIOSElementConverterby RemoteWebDriver when it is needed.io.appium.java_client.AppiumDriverwere redesigned. Now they require a subclass ofio.appium.java_client.internal.JsonToMobileElementConverter. Constructors ofio.appium.java_client.android.AndroidDriverandio.appium.java_client.ios.IOSDriverare same still.