new gradle plugins block + fatJar

[shauvik]

To build fatJar, apply this PR patch and simply call ./gradlew shadowJar

Change list

• Adding support for the new gradle plugins block
• Using the shadow plugin to create a fatJar for appium java client.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

• Usage of plugins block makes buildscript terse
• Allowing building fatJars helps makes life easy for cmd line usage.

[jsf-clabot]

All committers have signed the CLA.

[SrinivasanTarget]

I see shadow by default uses jfrog repo but we are publishing only to maven repo. Where are we specifying class path for owasp dependency check.

[shauvik]

Specifying it using the plugins block makes it download the dependencies from plugins.gradle.org... Specifically here: https://plugins.gradle.org/plugin/org.owasp.dependencycheck

There is also an option of the longer buildscript{} if you wanted to get dependencies the old way..

[SrinivasanTarget]

I got it but does it set the classpath as well? Also as i said before we need to explicitly set the repository as maven repo.

[shauvik]

So, I did some digging. Seems like gradle plugins block uses http://plugins.gradle.com/m2 which simply redirects all requests to jcenter.

~ curl -I https://plugins.gradle.org/m2/junit/junit/4.12/junit-4.12.pom
HTTP/1.1 303 See Other
Date: Fri, 27 Jan 2017 10:32:44 GMT
Content-Length: 0
Connection: keep-alive
Set-Cookie: __cfduid=dfb3ae2221aa16499509023673d8240ee1485513164; expires=Sat, 27-Jan-18 10:32:44 GMT; path=/; domain=.gradle.org; HttpOnly
Location: https://jcenter.bintray.com/junit/junit/4.12/junit-4.12.pom
Via: 1.1 vegur
Server: cloudflare-nginx
CF-RAY: 327b8adfa92f0a00-ATL

Also, it seems that the gradle plugins website keeps the classpath mapping, as documented in their submission and reclaiming of groupIds docs.
https://plugins.gradle.org/docs/submit
https://plugins.gradle.org/docs/reclaiming

[SrinivasanTarget]

Then as per your findings, we cannot accept this change since our main source of repository is maven central not jcenter. :(

[SrinivasanTarget]

Also may i know where does shadow benefits users? What is your usecase behind it?

[SrinivasanTarget]

@shauvik Can you make necessary changes to point the repo back to maven central?

[shauvik]

Done. Had to add a jcenter dependency to buildscript, since shadow is only available there.

[shauvik]

Heard a rant about having to download tons of jars while they were trying to get appium java-client to run. In their case, they were not using maven or gradle, and probably eclipse or command line. Selenium distributes a standalone version and also another version with a zip tarball of all libs, which makes it super simple to get started. shadow helps create such a fatJar easily. That's why i wanted to add it in appium!

…

On Fri, Jan 27, 2017 at 5:55 AM Srinivasan Sekar ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build.gradle <#560>: > @@ -1,3 +1,8 @@ +plugins { + id "org.owasp.dependencycheck" version "1.4.5" + id "com.github.johnrengelman.shadow" version "1.2.4" Also may i know where does shadow benefits users? What is your usecase behind it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#560>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIoKdcx-6UmUpXjX_Io2l1DIGdGJGQyks5rWc0OgaJpZM4LvbQe> .

[SrinivasanTarget]

@shauvik Ok Thanks

[SrinivasanTarget]

@shauvik Thanks

@TikhomirovSergey ping