Update to selenium 3.7.1 #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| id 'SrinivasanTarget' | ||
| }; | ||
| developer { | ||
| name 'Mykola Mokhnach' |
| * {@link org.openqa.selenium.Alert#authenticateUsing(Credentials)} | ||
| * It is deprecated because methods {@link org.openqa.selenium.Alert#setCredentials(Credentials)} and | ||
| * {@link org.openqa.selenium.Alert#authenticateUsing(Credentials)} were removed from selenium java client | ||
| * at 3.8.0. These listener method is going to be removed too. |
Contributor
There was a problem hiding this comment.
-> This listener method is going to be removed as well
| * {@link org.openqa.selenium.Alert#authenticateUsing(Credentials)}. | ||
| * It is deprecated because methods {@link org.openqa.selenium.Alert#setCredentials(Credentials)} and | ||
| * {@link org.openqa.selenium.Alert#authenticateUsing(Credentials)} were removed from selenium java client | ||
| * at 3.8.0. These listener method is going to be removed too. |
mykola-mokhnach
approved these changes
Dec 2, 2017
Contributor
mykola-mokhnach
left a comment
mykola-mokhnach
left a comment
There was a problem hiding this comment.
minor typos only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
beforeAuthenticationand afterAuthentication` became deprecared.Types of changes
Details
I can't to update the project to selenium 3.8.x because of mentioned methods. It should be removed safely and users should be warned.