fix base64 encoded string#231
Merged
KazuCocoa merged 1 commit intoappium:masterfrom Jul 13, 2018
Merged
Conversation
mykola-mokhnach
approved these changes
Jul 13, 2018
jlipps
approved these changes
Jul 13, 2018
KazuCocoa
commented
Jul 13, 2018
| screenshot = self.get_screenshot_as_base64() | ||
| with open(png_img_path, 'rb') as png_file: | ||
| b64_data = base64.encodestring(png_file.read()) | ||
| b64_data = base64.b64encode(png_file.read()).decode('UTF-8') |
Member
Author
There was a problem hiding this comment.
I could call json.dump(b64_data) without exception in Python2/3
with open('/Users/kazu/GitHub/python-client/sample.JPG', 'rb') as f:
b64_data = base64. b64encode(f.read()).decode('UTF-8')
json.dumps(b64_data)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: function
find_element_by_imagealways raise an exception: "TypeError: Object of type 'bytes' is not JSON serializable" #228encodestringgenerate byte data in Python 3. Thus, we should encode it to string.Python2.7
Python3.6
b64_datashould be base64 encoded string.This way is as same as https://github.com/SeleniumHQ/selenium/blob/6b5fe890da7d1592693d1dfcf795d882fc0426c5/py/selenium/webdriver/firefox/firefox_profile.py#L180 way.