feat: add warning to drop forceMjsonwp for W3C#567
Merged
KazuCocoa merged 7 commits intoappium:masterfrom Dec 21, 2020
Merged
Conversation
Contributor
|
I would rather have this commit for the next major version of the client (the one that supports selenium4). Removing this cap would enforce us to change the major version number anyway |
KazuCocoa
changed the title
Member
Author
|
Okay, I have no objection. I changed to print a warning instead as deprecated. |
appium/webdriver/webdriver.py
Outdated
| """Manage capabilities whether W3C format or MJSONWP format | ||
| """ | ||
| if _FORCE_MJSONWP in capabilities: | ||
| logger.warning("[Deprecated] 'forceMjsonwp' capability will be dropped") |
Contributor
There was a problem hiding this comment.
I would rather add a more detailed explanation of why the capability is going to be dropped and what is necessary to do in order to be ready for it
mykola-mokhnach
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forceMjsonwponly sends MJSONWP formatted capabilities, but selenium 4 and Appium is already going to focus on W3C.The initial motivation to allow forceMjsonwp was to help users so that they were able to move to W3C from MJSONWP in their timeline. chrome driver also already defaults to W3C spec, so it's a good time to drop it.