test: update tests to use find_element(by...)#674
Merged
KazuCocoa merged 5 commits intoappium:masterfrom Jan 1, 2022
Merged
Conversation
mykola-mokhnach
approved these changes
Jan 1, 2022
| # limitations under the License. | ||
|
|
||
| import httpretty | ||
| from selenium.webdriver.common import by |
Contributor
There was a problem hiding this comment.
I assume this particular was never executed and is invalid. The -windows uiautomation locator type is not supported on the server side and was removed from other clients.
Member
Author
There was a problem hiding this comment.
Yes. this lib also had a deprecation mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently made
find_element_by_xxxmethods as deprecated. It would be nice to all our tests follow it.