Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for providing the PKCS#12 password via environment variable to the resigner CLI, and documents the new usage pattern in the README.
Changes:
- Allow
--p12-passwordto be sourced from theP12_PASSWORDenvironment variable. - Document
P12_PASSWORDusage in the Quick Start section. - Update PKCS#12 creation guidance to mention
P12_PASSWORDas an alternative input mechanism.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents using P12_PASSWORD instead of --p12-password and updates related guidance. |
| cmd/resigner/main.go | Adds EnvVars: ["P12_PASSWORD"] to the p12-password CLI flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.