Skip to content

feat: add version#6

Merged
KazuCocoa merged 1 commit into
mainfrom
add-version
May 14, 2026
Merged

feat: add version#6
KazuCocoa merged 1 commit into
mainfrom
add-version

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 14, 2026 05:06
@KazuCocoa KazuCocoa merged commit 2957093 into main May 14, 2026
5 checks passed
@KazuCocoa KazuCocoa deleted the add-version branch May 14, 2026 05:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches build version metadata from a git commit hash to a git tag, and enables the standard --version CLI flag in the resigner binary.

Changes:

  • Replace GIT_COMMIT (via git describe --always --long --abbrev=12 --dirty) with GIT_TAG (via git describe --tags --always) in the Makefile and inject it as main.VCSRevision.
  • Configure cli.VersionFlag with Name: "version" and a usage description so users can run --version, while avoiding a short alias that conflicts with -v verbose.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Makefile Replace commit-hash-based version with git-tag-based version injected via ldflags.
cmd/resigner/main.go Enable --version flag with explicit name/usage instead of disabling the version flag entirely.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants