refactor: search contexts and its structure #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Jul 28, 2017
| uiautomation: '-ios uiautomation', | ||
| predicate: '-ios predicate string', | ||
| class_chain: '-ios class chain' | ||
| }.freeze |
There was a problem hiding this comment.
hm...
I re-think we should separate each finder to android/ios, and each automation name.
For example, class_chain is able to use only for xcuitest.
KazuCocoa
force-pushed
the
refactor_search_contexts
branch
from
5d771f1 to
12b2947
Compare
KazuCocoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/appium_lib/common/search_context.rbbecause no need to separate them.