Upgrade with Step Degradation Fix + Re-enable Goodput Monitoring#1341
Merged
Conversation
dipannita08
force-pushed
the
gp-integration-v15
branch
from
a6e92e8 to
14bd474
Compare
dipannita08
changed the title
dipannita08
changed the title
Ethanlm
approved these changes
Sep 24, 2025
Ethanlm
reviewed
Sep 24, 2025
ruhanprasad
reviewed
Sep 24, 2025
Ethanlm
approved these changes
Sep 25, 2025
dipannita08
force-pushed
the
gp-integration-v15
branch
from
2669f03 to
52064d4
Compare
changlan
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the
ml-goodput-measurementpackage version to 0.0.15 to integrate a critical performance fix for the GoodputMonitor.Context
This release contains a major refactor GoodputMonitor to use multiprocessing throughout all APIs, instead of multithreading.
A step time degradation caused on a previous run caused by Python's Global Interpreter Lock (GIL) starving the main process due to the GoodputMonitor's tight-computation loops when there are multiple restarts is resolved with this fix.
Tests: