Skip to content

Do not make hidden directory inside builder shim#71

Merged
JaewonHur merged 4 commits intoapple:mainfrom
JaewonHur:fix-docker-ignore-2
Mar 14, 2026
Merged

Do not make hidden directory inside builder shim#71
JaewonHur merged 4 commits intoapple:mainfrom
JaewonHur:fix-docker-ignore-2

Conversation

@JaewonHur
Copy link
Copy Markdown
Contributor

@JaewonHur JaewonHur commented Mar 13, 2026

Previous docker ignore fix (#68) has race bug when syncing files to the buildkit daemon. Upon file request from buildkitd, the FSSync proxy in builder shim checks _checksum variable to check if build context is synced inside VM, and responds differently: i) if not, it forwards a request to the proxy outside to get the file, ii) if synced, it immediately provides the file.

However, since #68 creates a hidden docker directory inside builder shim during sync, if the request for Dockerfile is received before the sync, it just forwards the request outside, which doesn't know that hidden directory.

This PR assumes the directory is created outside, so that such request can be handled.

@JaewonHur JaewonHur requested a review from jglogan March 14, 2026 04:01
@JaewonHur JaewonHur merged commit ef922da into apple:main Mar 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants