feat: add help for cli plugin #1068
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
jglogan
reviewed
Jan 20, 2026
| // Regular ol `command` with no args will get caught by DefaultCommand. --help | ||
| // on the root command will land here. | ||
| let containsHelp = fullArgs.contains("-h") || fullArgs.contains("--help") | ||
| let containsHelp = fullArgs.contains("-h") || fullArgs.contains("--help") || fullArgs.contains("help") |
Contributor
There was a problem hiding this comment.
What happens if I run:
container --debug help
Thanks, this is a good start! Perhaps extract containsHelp() into a private method that works for all the possibilities you can think of.
Contributor
|
@tico88612 Could you also rebase onto the current main? Our action runners got updated and you'll need the new workflows for your PR to build. Thanks! |
Contributor
Author
|
@jglogan I will update this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fix #387
Here's how I see the issue #387, though I'm not entirely sure.
Testing