Makes bootstrap env parameter compatible with older clients.#1434
Merged
jglogan merged 1 commit intoapple:mainfrom Apr 21, 2026
Merged
Makes bootstrap env parameter compatible with older clients.#1434jglogan merged 1 commit intoapple:mainfrom
jglogan merged 1 commit intoapple:mainfrom
Conversation
- Closes apple#1433. - Renames `env` parameter to `dynamicEnv` to differentiate these special-case environment variables from the standard container environment. - Use `[String: String]` instead of `[String: String]?`. - Default to `[:]` when an down-revision client calls bootstrap without supplying `dynamicEnv`.
JaewonHur
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envbootstrap parameter breaks XPC API compatibility. #1433.envparameter todynamicEnvto differentiate these special-case environment variables from the standard container environment.[String: String]instead of[String: String]?.[:]when an down-revision client calls bootstrap without supplyingdynamicEnv.Type of Change
Motivation and Context
Preserve XPC API compatibility, disambiguate
dynamicEnvvs regular container environment variables.Testing