Rearrange shape of JSON output for images#1652
Merged
Merged
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
rearrange_image_resource
branch
from
c0d4f4c to
5473ba7
Compare
Code Coverage
|
jglogan
approved these changes
Jun 5, 2026
2 tasks
1 task
katiewasnothere
added a commit
that referenced
this pull request
Jun 5, 2026
#1652 rearranged the JSON output for image resources and included a duplicate "name" field. After further discussion, we've decided to remove the duplicate field. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR changes the shape of the JSON output for image resources to align closer with
VolumeResourceandNetworkResource. This includes adding "creationDate" in theconfigurationsection of the image output. This PR additionally cleans up some of the logic around theImageResourcestruct construction.Testing