Clear a line with spaces to prevent a race between stderr and stdout#18
Merged
Clear a line with spaces to prevent a race between stderr and stdout#18
stderr and stdout#18Conversation
adityaramani
approved these changes
Jun 5, 2025
katiewasnothere
pushed a commit
that referenced
this pull request
Jun 5, 2025
…ut` (#18) This PR resolves a race with `\u{001B}[2K`, but not with `\r`, which will be addressed in a separate PR by moving progress updates to `stdout`. Please test it in a small window in your terminal application on the `users/a_ramani/install-ux` branch using commands: ``` bin/container system stop make cleancontent bin/container system start ``` You should see the prompt: > Install the recommended default kernel from [https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]? [Y/n]:
owenarthur
pushed a commit
to owenarthur/container
that referenced
this pull request
Jun 10, 2025
…ut` (apple#18) This PR resolves a race with `\u{001B}[2K`, but not with `\r`, which will be addressed in a separate PR by moving progress updates to `stdout`. Please test it in a small window in your terminal application on the `users/a_ramani/install-ux` branch using commands: ``` bin/container system stop make cleancontent bin/container system start ``` You should see the prompt: > Install the recommended default kernel from [https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]? [Y/n]:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a race with
\u{001B}[2K, but not with\r, which will be addressed in a separate PR by moving progress updates tostdout. Please test it in a small window in your terminal application on theusers/a_ramani/install-uxbranch using commands:You should see the prompt: