Merged
Conversation
adityaramani
reviewed
Jun 6, 2025
README.md
Outdated
Contributor
There was a problem hiding this comment.
Is moving this bellow the gif intentional?
Contributor
Author
There was a problem hiding this comment.
yep, sort of an A/B test, we'll see what folks like better
egernst
reviewed
Jun 6, 2025
Contributor
egernst
left a comment
egernst
left a comment
There was a problem hiding this comment.
This looks good - similar question from what Aditya left on whether you want Container heading before or after gif. Thanks.
- Extract README sections into BUILDING and CONTRIBUTING documents. This should work better than sections in README as it keeps the README short, and the BUILDING and CONTRIBUTING files will stand out in the file list. - Merged localdev document into BUILDING. - Fixed broken links. - Changed DNS setup so later DNS-dependent steps should work. - Added h1 and link to SECURITY document.
adityaramani
approved these changes
Jun 6, 2025
owenarthur
pushed a commit
to owenarthur/container
that referenced
this pull request
Jun 10, 2025
- Extract README sections into BUILDING and CONTRIBUTING documents. This should work better than sections in README as it keeps the README short, and the BUILDING and CONTRIBUTING files will stand out in the file list. - Merged localdev document into BUILDING. - Fixed broken links. - Changed DNS setup so later DNS-dependent steps should work. - Added h1 and link to SECURITY document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.