Add per-container networking flag to ContainerManager.create()#549
Merged
dcantah merged 1 commit intoapple:mainfrom Feb 23, 2026
Merged
Add per-container networking flag to ContainerManager.create()#549dcantah merged 1 commit intoapple:mainfrom
dcantah merged 1 commit intoapple:mainfrom
Conversation
dcantah
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
networking: Bool = trueparameter toContainerManager.create()so callers can opt out of network interface creation on a per-container basis.Motivation
Currently,
ContainerManager.create()unconditionally allocates a vmnet network interface for every container (when the manager has a network configured). Some use cases don't need network access and benefit from having it disabled to reduce attack surface.There's no way to achieve this today without either:
ContainerManagerwithout a network (which disables networking for all containers)config.interfacesin the configuration closure (which wastes an IP allocation from the vmnet pool sincenetwork.create(id)has already been called)Changes
networking: Bool = trueto all threecreate()overloads onContainerManagerfalse,self.network?.create(id)is skipped entirely. No interface is allocated, and no DNS is configured.releaseNetwork/deleteremain safe to call regardless, sinceAllocator.releasesilently ignores unknown IDs.testNetworkingFalseSkipsInterfaceCreationusing the existingNilGatewayNetworkfixturetestNetworkingDisabledandtestNetworkingEnabledthat create containers through a network-enabledContainerManagerand verify the presence/absence ofeth0via/sys/class/net/