Derive the block size from the log block size#662
Merged
crosbymichael merged 3 commits intoapple:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
|
Just for my reference, where did you find the log block size to be 2? |
Contributor
Author
This is what it has to be to have the block size of 4 KiB ( |
crosbymichael
approved these changes
Apr 9, 2026
wlan0
pushed a commit
that referenced
this pull request
Apr 10, 2026
Restores a configurable block size in the EXT4 formatter. #662 resolved a conflict between the hardcoded log block size and a user-provided block size, but removed the later. This PR restores the configurable block size without creating the conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives the block size from the log block size.