Open
Conversation
jglogan
force-pushed
the
ext4-journal-2
branch
4 times, most recently
from
d8e799b to
61c99aa
Compare
- Set journal backup type. - Trailing comment after superblock setup listing fields we implictly left zero. - Enforce minimum journal size of 1024 blocks (`EXT4_MIN_JOURNAL_BLOCKS`). - Fix byte ordering of `i_size` and `i_size_hi` in the s_jnl_blocks.
- The journal construction previously consumed bytes from the caller's `minDiskSize` value. `close()` now stashes the reserved GDT block count based on the pre-journal total block count, and then initializes the journal and increases the total accordingly. - Eliminates now-inapplicable "journal too large" checks. - Ensure that block count will fit UInt32 in formatter `init()` and `close()`. - Add readback validation to journaled filesystem unit tests. - Add readback check and volume mount for journaled filesystem integration tests. - PR feedback - clarify JBD2 endianness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXT4.Formatter.init(), with nil default specifying the current no-journal filesystem configuration. Otherwise the parameter value contains the journal size and mode.minDiskSizeparameter for formatter init specifies the minimum usable capacity of the resulting filesystem. The resulting disk image grows past this value to accommodate the filesystem on-disk structures, including the journal if specified.