Refactor ArchiveWriter to expose archiving each URL independently#693
Merged
JaewonHur merged 1 commit intoapple:mainfrom May 1, 2026
Merged
Refactor ArchiveWriter to expose archiving each URL independently#693JaewonHur merged 1 commit intoapple:mainfrom
JaewonHur merged 1 commit intoapple:mainfrom
Conversation
dcantah
reviewed
Apr 21, 2026
Contributor
|
@JaewonHur How much overlap is there with #652? |
Contributor
|
Should we rebase this one? |
JaewonHur
force-pushed
the
archive-urls-oss
branch
from
3865df5 to
291b859
Compare
Member
|
You need to sign your commits. The change lgtm at this point after. Just squash everything down to 1 commit |
JaewonHur
force-pushed
the
archive-urls-oss
branch
from
291b859 to
fb1e84b
Compare
This PR refactors `ArchiveWriter` to add an API `archive(_ paths: base:)`. This API is used to archive the contents at each URL independently, similar to doing `tar -cvf archive.tar foo.bin /bar/baz.txt`.
JaewonHur
force-pushed
the
archive-urls-oss
branch
from
f067fd4 to
2c97b73
Compare
egernst
approved these changes
May 1, 2026
Contributor
egernst
left a comment
egernst
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
ArchiveWriterto add an APIarchive(_ paths: base:). This API is used to archive the contents at each URL independently, similar to doingtar -cvf archive.tar foo.bin /bar/baz.txt.