-
Notifications
You must be signed in to change notification settings - Fork 739
Support quatization of loadConstantND #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Ghost-LZW - Please include a unit test for this fix, i.e. a unit test which fails without your fix but passes with your fix. Thank you. |
18911e3 to
36a928d
Compare
The corresponding unit test has been added |
|
Thanks for adding the unit test. This change looks good to me. I have kicked off a CI run for this change: If that passes, I plan to merge this pull request. |
failed case is |
|
I restarted the failed job and it failed again. However this test is passing in A PSNR 8 is quite poor. I suggest you dig into what this unit test is doing. |
36a928d to
abb5b95
Compare
|
Changes look good. Thanks. Updated CI: https://gitlab.com/coremltools1/coremltools/-/pipelines/988268661 If CI passes, I will merge. |
|
@Ghost-LZW - I'm still seeing the same PSNR Depthwise Convolution failure on the updated CI run. |
|
@TobyRoseman sorry for late reply. Busy for other things recently, I'll dig into this unit test until I can give it some time. |
|
Thanks for adding unit tests. I've kicked off a CI for this change: |
|
Over the last weekend, I attempted to rebase to origin/main in order to investigate the reason behind the failure of PSNR Depthwise Convolution. However, I was unable to successfully build the CI environment, so I haven't been able to do anything yet. Later on, the CI process passed, which seemed a bit strange to me. |
|
The most recent CI run is good. Don't worry about the previous CI. It's likely unrelated to your change. If you can remove that |
ed63b65 to
6ba6470
Compare
|
Thanks @Ghost-LZW! |
No description provided.