Fix rename_feature skipping layer outputs when rename_inputs=False#2676
Merged
TobyRoseman merged 1 commit intoApr 28, 2026
Merged
Conversation
The if rename_outputs branch sat inside if rename_inputs, so the layer-output rename only ran when both flags were true. Move the branch out one level so the two flags become independent, matching the documented behavior. Fixes apple#2494
Collaborator
TobyRoseman
approved these changes
Apr 28, 2026
Collaborator
|
Thanks @eyupcanakman for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename_feature(..., rename_inputs=False, rename_outputs=True)on aneuralNetworkspec renamesdescription.outputbut leaves the producing layer'soutputfield unchanged. The model then fails to compile with "Interface specifies output X which is not produced by any layer in the neural network".The
if rename_outputs:branch sat insideif rename_inputs:, so the layer-output rename only ran when both flags were true. The fix moves the branch out one level so the two flags become independent.Added
test_rename_output_neural_network.test_rename_outputnext to it uses aglmRegressorspec, which never reaches the per-layer loop.Fixes #2494