refactor: move the density clustering code to its own internal package #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Aug 27, 2025
| /** Cluster identifier */ | ||
| identifier: number; | ||
| /** The total density */ | ||
| sum_density: number; |
Member
There was a problem hiding this comment.
I suppose these are mapping to native names so we use snake case instead of camel case which would be common in js?
Collaborator
Author
There was a problem hiding this comment.
Yes, they map to Rust code. I think camel case would be better for JS, but this PR is just to move the code to a new home, so no changes to the naming.
| { | ||
| "name": "@embedding-atlas/density-clustering", | ||
| "version": "0.0.0", | ||
| "private": true, |
Member
There was a problem hiding this comment.
Do we want to publish this as a package or leave it internal?
Collaborator
Author
There was a problem hiding this comment.
The API is already published as part of the embedding-atlas npm package.
donghaoren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the density clustering JS code from inside the "component" package to its own package for better separation.