Skip to content

Conversation

@spraza
Copy link
Collaborator

@spraza spraza commented Jan 22, 2026

Fb has tagged the rocksdb v8.11.5 release: facebook/rocksdb#14145 (comment), https://github.com/facebook/rocksdb/releases/tag/v8.11.5

So we can go back to version based approach. This PR does that.

100K running: 20260122-001902-praza-fdb-7.4-rocksdb-8.11.-04e8014b8255b29a compressed=True data_size=40238024 duration=5066335 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=2:37:11 sanity=False started=100000 stopped=20260122-025613 submitted=20260122-001902 timeout=5400 username=praza-fdb-7.4-rocksdb-8.11.5-97a59accef3674ab24406ebe41d5cb6a50af4d8d

Also ensured fdbserver --version reports correct output:

FoundationDB 7.4 (v7.4.6)
source version 97a59accef3674ab24406ebe41d5cb6a50af4d8d
protocol fdb00b074000000
rocksdb 8.11.5

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@spraza spraza changed the title fdb release 7.4: use rocksdb v8.11.5 FDB release 7.4: use RocksDB v8.11.5 Jan 22, 2026
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 97a59ac
  • Duration 0:51:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 97a59ac
  • Duration 1:00:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 97a59ac
  • Duration 1:05:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@neethuhaneesha neethuhaneesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the downgrade from versions 8.11.5 to 8.11.4 ? Just to ensure we are not seeing any issues.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 97a59ac
  • Duration 2:17:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@spraza
Copy link
Collaborator Author

spraza commented Jan 22, 2026

Did you check the downgrade from versions 8.11.5 to 8.11.4 ? Just to ensure we are not seeing any issues.

I have initial positive signal from simulation i.e. 20260122-001902-praza-fdb-7.4-rocksdb-8.11.-04e8014b8255b29a has downgrade tests that go from this PR (rocksdb 8.11.5) to fdb 7.3 (rocksdb 8.11.4). I'm also planning to test in perf cluster before cutting 7.4 release.

@spraza
Copy link
Collaborator Author

spraza commented Jan 22, 2026

Mac build has a known issue. 100K and other signals are green so merging.

@spraza spraza merged commit 0490f75 into apple:release-7.4 Jan 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants