Use CONFIG mode for Boost on Windows to support CMake 3.30#12688
Merged
jzhou77 merged 3 commits intoapple:mainfrom Feb 13, 2026
Merged
Use CONFIG mode for Boost on Windows to support CMake 3.30#12688jzhou77 merged 3 commits intoapple:mainfrom
jzhou77 merged 3 commits intoapple:mainfrom
Conversation
jzhou77
approved these changes
Feb 10, 2026
Contributor
jzhou77
left a comment
There was a problem hiding this comment.
We don't have CI test for Windows. Can you confirm this works on Windows? Then I'll merge.
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Author
|
@jzhou77 I'll checkout if it's present if not I'll make sure to have one. |
Contributor
Author
|
@jzhou77 I added github action and here are the logs that shows the build is good. I didnt have the windows machine. I tested it using github action providing the same build arguement. CMake Detection (15.1s) |
jzhou77
approved these changes
Feb 11, 2026
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
|
Joshua failure are unrelated to cmake changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12630
Modernizes Boost dependency handling on Windows to use CONFIG mode for CMake 3.30+ compatibility. Removes reliance on deprecated FindBoost module by using Boost's native BoostConfig.cmake.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)