Skip to content

Use CONFIG mode for Boost on Windows to support CMake 3.30#12688

Merged
jzhou77 merged 3 commits intoapple:mainfrom
Ronitsabhaya75:boost-cmake-fix
Feb 13, 2026
Merged

Use CONFIG mode for Boost on Windows to support CMake 3.30#12688
jzhou77 merged 3 commits intoapple:mainfrom
Ronitsabhaya75:boost-cmake-fix

Conversation

@Ronitsabhaya75
Copy link
Copy Markdown
Contributor

Fixes #12630

Modernizes Boost dependency handling on Windows to use CONFIG mode for CMake 3.30+ compatibility. Removes reliance on deprecated FindBoost module by using Boost's native BoostConfig.cmake.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@Ronitsabhaya75 Ronitsabhaya75 marked this pull request as ready for review February 10, 2026 00:49
Copy link
Copy Markdown
Contributor

@jzhou77 jzhou77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have CI test for Windows. Can you confirm this works on Windows? Then I'll merge.

@jzhou77 jzhou77 closed this Feb 10, 2026
@jzhou77 jzhou77 reopened this Feb 10, 2026
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 05660d1
  • Duration 0:06:52
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 05660d1
  • Duration 0:06:56
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 05660d1
  • Duration 0:23:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 05660d1
  • Duration 0:42:56
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 05660d1
  • Duration 0:52:27
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 05660d1
  • Duration 0:54:13
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 05660d1
  • Duration 2:03:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@Ronitsabhaya75
Copy link
Copy Markdown
Contributor Author

@jzhou77 I'll checkout if it's present if not I'll make sure to have one.

@Ronitsabhaya75
Copy link
Copy Markdown
Contributor Author

Ronitsabhaya75 commented Feb 10, 2026

@jzhou77 I added github action and here are the logs that shows the build is good. I didnt have the windows machine. I tested it using github action providing the same build arguement.

installing 76/76 packages: 
✓ boost-filesystem:x64-windows@1.90.0 
✓ boost-iostreams:x64-windows@1.90.0
✓ boost-serialization:x64-windows@1.90.0
✓ boost-system:x64-windows@1.90.0 
✓ boost-program-options:x64-windows@1.90.0 
✓ boost-url:x64-windows@1.90.0 
✓ boost-context:x64-windows@1.90.0

Total install time: 7.6 min All requested installations completed successfully

CMake Detection (15.1s)

-- Building for: Visual Studio 17 2022 
-- The C compiler identification is MSVC 19.44.35222.0
-- Found ZLIB: C:/vcpkg/installed/x64-windows/lib/zlib.lib 
-- Found BZip2: C:/vcpkg/installed/x64-windows/lib/bz2.lib
-- Found LibLZMA: C:/vcpkg/installed/x64-windows/lib/lzma.lib
-- SUCCESS: Boost found using CONFIG mode!
-- Boost version: 1.90.0 
-- Boost include dirs: C:/vcpkg/installed/x64-windows/include
-- Configuring done (15.1s)```

@jzhou77 jzhou77 closed this Feb 11, 2026
@jzhou77 jzhou77 reopened this Feb 11, 2026
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: a01a03d
  • Duration 0:08:30
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: a01a03d
  • Duration 0:08:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: a01a03d
  • Duration 0:24:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: a01a03d
  • Duration 0:44:14
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: a01a03d
  • Duration 0:55:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: a01a03d
  • Duration 0:59:00
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: a01a03d
  • Duration 1:56:15
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit 585d0e2 into apple:main Feb 13, 2026
3 of 7 checks passed
@jzhou77
Copy link
Copy Markdown
Contributor

jzhou77 commented Feb 13, 2026

Joshua failure are unrelated to cmake changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost dependency should be handled better

3 participants