Skip to content

Fix Redwood restart compatibility with legacy XOR page encoding#12917

Merged
gxglass merged 2 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/fix-encryption-restarting
Apr 2, 2026
Merged

Fix Redwood restart compatibility with legacy XOR page encoding#12917
gxglass merged 2 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/fix-encryption-restarting

Conversation

@tclinkenbeard-oai
Copy link
Copy Markdown
Collaborator

Even with encryptModes=['disabled'], 7.3 Redwood would randomly enable encryption in simulation. #12667 removed the encryption-at-rest feature, but this occasionally causes restarting test failures when encrypted Redwood pages are read upon restart.

This PR adds minimal test-only decryption support to Redwood, allowing these simulation tests to pass.

The issue was detected in CI for #12915:

fdbserver-7.3.63 -r simulation --crash --logsize 1024MB -f src/foundationdb/tests/restarting/from_7.3.0/ConfigureTestRestart-1.toml --buggify off --seed 105248272
fdbserver-45da11c439588d9f9e3e4ed6076d9e359285aa76 -r simulation --crash --logsize 1024MB -f src/foundationdb/tests/restarting/from_7.3.0/ConfigureTestRestart-2.toml --buggify on --seed 105248273

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: e51f9cd
  • Duration 0:24:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: e51f9cd
  • Duration 0:42:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: e51f9cd
  • Duration 0:57:08
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: e51f9cd
  • Duration 1:00:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: e51f9cd
  • Duration 1:55:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@gxglass gxglass merged commit 9c13e63 into apple:main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants