Cherrypick docs and formatting fixes#247
Merged
brownleej merged 3 commits intoapple:release-5.1from Apr 24, 2018
Merged
Conversation
brownleej
reviewed
Apr 24, 2018
bindings/go/src/fdb/fdb.go
Outdated
|
|
||
| // Determines if an API version has already been selected, i.e., if | ||
| // APIVersion or MustAPIVersion have already been called. | ||
| func IsAPIVersionSelected() bool { |
Contributor
There was a problem hiding this comment.
Are these functions intended to be added onto the release-5.1 branch, or did they get picked up with another change?
Contributor
Author
There was a problem hiding this comment.
Oh, good catch. No, they weren't intended to be added. Let me remove them, but we should make sure they don't disappear when we merge release-5.1 into release-5.2.
Contributor
Author
There was a problem hiding this comment.
Okay, I think the way I did it, it won't cause a problem when we merge, but I guess we'll find out.
alecgrieser
force-pushed
the
cherrypick-docs-and-formatting-fixes
branch
from
24f8f9f to
731a8dc
Compare
sfc-gh-jfu
pushed a commit
to sfc-gh-jfu/foundationdb
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some fixes to our Java examples and also some go linting fixes that have been merged into master that I think should be pulled into release-5.1.