Skip to content

removed binding tester references to dev_null_is_web_scale#261

Merged
alecgrieser merged 5 commits intoapple:release-5.1from
etschannen:release-5.1
Apr 27, 2018
Merged

removed binding tester references to dev_null_is_web_scale#261
alecgrieser merged 5 commits intoapple:release-5.1from
etschannen:release-5.1

Conversation

@etschannen
Copy link
Contributor

No description provided.

@etschannen etschannen requested a review from brownleej April 26, 2018 21:37
Copy link
Contributor

@ajbeamon ajbeamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't all of them. The option also appears in Java, at least.

@alecgrieser
Copy link
Contributor

I believe that generated.go also needs to be regenerated to remove the option.

@alecgrieser
Copy link
Contributor

And it's also in the flow tester.

Copy link
Contributor

@alecgrieser alecgrieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

@alecgrieser alecgrieser merged commit 5fbfd1e into apple:release-5.1 Apr 27, 2018
sfc-gh-tclinkenbeard pushed a commit to sfc-gh-tclinkenbeard/foundationdb that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants