Replace pkl-gen-go with @pkl.go/gen.pkl tool#209
Merged
HT154 merged 3 commits intoapple:mainfrom Feb 27, 2026
Merged
Conversation
stackoverflow
approved these changes
Feb 26, 2026
Contributor
stackoverflow
left a comment
stackoverflow
left a comment
There was a problem hiding this comment.
Much better!
Some small issues. Approving to unblock.
Contributor
There was a problem hiding this comment.
Did we only need the NOTICE for pkl-gen-go?
What about msgpack which we still use?
Contributor
Author
There was a problem hiding this comment.
My understanding is that the notice is specific to pkl-gen-go because we were compiling these libraries and redistributing them in binary form. I'm double checking on how to proceed here.
Contributor
Author
There was a problem hiding this comment.
Erred toward keeping this for now, just in case. Changed the verbiage to no refer to pkl-gen-go.
HT154
force-pushed
the
gen-cmd
branch
6 times, most recently
from
7373414 to
79b6c99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.