Fix native build#1636
Merged
Merged
Conversation
HT154
approved these changes
Jun 2, 2026
Contributor
HT154
left a comment
HT154
left a comment
There was a problem hiding this comment.
LGTM
It'd be really slick if we could somehow detect git diffs in methods above the truffle boundary and run native builds on PRs automatically. Probably difficult to achieve in practice, but a gal can dream!
Member
Author
|
It should be possible to statically check if we are missing truffle boundaries without requiring native builds too. Would be a nice improvement to our dev workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[native-pkl-cli]