Skip to content

Conversation

@bioball
Copy link
Member

@bioball bioball commented Dec 18, 2024

Don't use the system Java on Windows builds, instead download them from Adoptium.

Also:

  • Fail job if curl returns a 4xx status code
  • Add java version to GradleJob

@bioball bioball marked this pull request as ready for review December 18, 2024 00:11
curl -L \
https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.9%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz -o /tmp/jdk.tar.gz
curl -Lf \
https://github.com/adoptium/temurin17-binaries/releases/download/jdk-jdk-17.0.9%2B9.1/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz -o /tmp/jdk.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new URLs are returning 404 for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

@bioball bioball merged commit 9982511 into apple:main Dec 19, 2024
5 checks passed
@bioball bioball deleted the fix-windows-build branch December 19, 2024 17:23
bioball added a commit that referenced this pull request Jan 17, 2025
Don't use the system Java on Windows builds, instead download them from Adoptium.

Also:

* Fail job if curl returns a 4xx status code
* Add java version to `GradleJob`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants