Allow overriding the pkl version inpkl_package#101
Merged
sitaktif merged 2 commits intoapple:mainfrom Sep 24, 2025
Merged
Conversation
sitaktif
force-pushed
the
pkl-version-override
branch
2 times, most recently
from
7fddbf2 to
9ed2492
Compare
sitaktif
force-pushed
the
pkl-version-override
branch
from
9ed2492 to
91ecdf7
Compare
KushalP
approved these changes
Sep 23, 2025
sitaktif
force-pushed
the
pkl-version-override
branch
from
91ecdf7 to
aae8d0f
Compare
This attribute set the 'PKL_PACKAGE_VERSION' env var during the Pkl project package step. rdar://160952236 ([rules_pkl] allow setting the Pkl package version dynamically)
Move PklPackage files into separate Bazel packages, add tests to the integration suite and add a test case for version override.
sitaktif
force-pushed
the
pkl-version-override
branch
from
aae8d0f to
d3c4f86
Compare
Collaborator
Author
|
Rebased the changes, and also simplified the first two |
KushalP
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding the pkl version of a
pkl_packagetarget with aversionattribute.In order to keep that version in sync with the
PklProjectfile, the user can use thePKL_PACKAGE_VERSIONenv var with e.g.version = read?("env:PKL_PACKAGE_VERSION) ?? "0.0.0-dev".