build: update rules_bazel_integration_test Bazel dep#105
Merged
sitaktif merged 1 commit intoapple:mainfrom Oct 1, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sitaktif
force-pushed
the
update-rules-bazel-integration-test
branch
from
12789ec to
fd86512
Compare
KushalP
requested changes
Oct 1, 2025
sitaktif
force-pushed
the
update-rules-bazel-integration-test
branch
from
fd86512 to
ca47666
Compare
KushalP
reviewed
Oct 1, 2025
| bazel_dep(name = "bazel_skylib", version = "1.7.1") | ||
| bazel_dep(name = "platforms", version = "0.0.11") | ||
|
|
||
| bazel_dep(name = "rules_bazel_integration_test", version = "0.34.0", dev_dependency = True) |
Contributor
There was a problem hiding this comment.
Minor nit: does this need to be here, or can it go with the other block of dev_dependency = True deps?
KushalP
approved these changes
Oct 1, 2025
Contributor
KushalP
left a comment
KushalP
left a comment
There was a problem hiding this comment.
Approving to unblock. See my comment about whether it needs to be placed where it is, or if it can go with the other dev_dependency = True devs.
Version 0.34.0 contains a fix that ensures that the hermetic python toolchain used by the project is not overridden by the un-hermetic one defined in rules_bazel_integration_test.
sitaktif
force-pushed
the
update-rules-bazel-integration-test
branch
from
ca47666 to
4f51635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.34.0 contains a fix that ensures that the hermetic python toolchain used by the project is not overridden by the un-hermetic one defined in rules_bazel_integration_test.