Use hermetic zipper tool in pkl_java_resource_jar#116
Merged
KushalP merged 2 commits intoapple:mainfrom Nov 6, 2025
Merged
Conversation
Replace system zip/unzip commands with Bazel's hermetic zipper tool to ensure the rule works in remote build environments (RBE) where system commands may not be available. The previous implementation used shell commands 'unzip' and 'zip' which caused "command not found" errors in RBE. This change uses @bazel_tools//tools/zip:zipper for both extraction and creation, making the build hermetic and portable. Additionally, the implementation now properly strips the './' prefix from file paths using sed to avoid invalid ZIP entries that would cause "ZIP file can't be opened" errors.
KushalP
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace system zip/unzip commands with Bazel's hermetic zipper tool to ensure the rule works in remote build environments (RBE) where system commands may not be available.
The previous implementation used shell commands 'unzip' and 'zip' which caused "command not found" errors in RBE. This change uses @bazel_tools//tools/zip:zipper for both extraction and creation, making the build hermetic and portable.
Additionally, the implementation now properly strips the './' prefix from file paths using sed to avoid invalid ZIP entries that would cause "ZIP file can't be opened" errors.