Skip to content

Merge README blocks referring to minimum required versions#118

Merged
KushalP merged 2 commits intoapple:mainfrom
KushalP:merge-required-versions
Nov 10, 2025
Merged

Merge README blocks referring to minimum required versions#118
KushalP merged 2 commits intoapple:mainfrom
KushalP:merge-required-versions

Conversation

@KushalP
Copy link
Copy Markdown
Contributor

@KushalP KushalP commented Nov 10, 2025

No description provided.

@KushalP KushalP enabled auto-merge (squash) November 10, 2025 12:01
@madrob
Copy link
Copy Markdown

madrob commented Nov 10, 2025

Can we go further and say that rules_pkl requires jdk17? It’s a bit strange to say that we need pkl 0.29 and then in the next line tell me about an older version that I can’t use anyway.

@KushalP KushalP disabled auto-merge November 10, 2025 15:02
@KushalP
Copy link
Copy Markdown
Contributor Author

KushalP commented Nov 10, 2025

Can we go further and say that rules_pkl requires jdk17? It’s a bit strange to say that we need pkl 0.29 and then in the next line tell me about an older version that I can’t use anyway.

Good call. I've pushed another commit which says as much.

@KushalP KushalP merged commit c4f2171 into apple:main Nov 10, 2025
3 checks passed
@KushalP KushalP deleted the merge-required-versions branch November 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants