build: reenable integration tests#125
Conversation
c7b2abe to
9472c19
Compare
|
Looks like there build errors: |
|
I must have missed something, because |
9472c19 to
c299ffa
Compare
sigh |
|
According to https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories, the runner should have 14GB of disk, which is probably a bit tight indeed. I suggest we use the same output base of all the integration tests (which should be fine since they are exclusive). |
d764d78 to
cb64d60
Compare
Also set the integration test workspaces output base to a single output base to avoid high disk usage on Github Actions.
The integration tests were deadlocking on trying to use the same output base as the root bazel invocation because of a value set in the home bazelrc by the Github Actions setup-bazel extension. Now that a specific, distinct output base is set in a preceding step, integration tests can be re-enabled.
cb64d60 to
cca232a
Compare
|
The check-pkl-github-actions check is failing due to a 503 on github: EDIT: transient failure 👍 |
KushalP
left a comment
There was a problem hiding this comment.
Thank you.
Can you create issues for these hacks we've had to apply to the respective bazel-contrib/setup-bazel and rules_bazel_integration_test projects please?
|
Thanks @KushalP. Regarding the issues, I created bazel-contrib/setup-bazel#108 on the I don't think |
The integration tests were deadlocking on trying to use the same output base as the root bazel invocation because of a value set in the home bazelrc by the Github Actions setup-bazel extension. Clearing the output base value in the integration test invocations works around the issue.
Related-to: bazel-contrib/setup-bazel#108.