Skip to content

build: fix field name in test report GHA workflow#128

Merged
sitaktif merged 1 commit intoapple:mainfrom
sitaktif:test-report-regexp-field
Nov 25, 2025
Merged

build: fix field name in test report GHA workflow#128
sitaktif merged 1 commit intoapple:mainfrom
sitaktif:test-report-regexp-field

Conversation

@sitaktif
Copy link
Copy Markdown
Collaborator

@KushalP
Copy link
Copy Markdown
Contributor

KushalP commented Nov 25, 2025

Looks like the YAML file is generated:

# This file was generated from a template using https://github.com/StefMa/pkl-gha

@sitaktif
Copy link
Copy Markdown
Collaborator Author

Indeed I went a bit fast on that one; good news is that @bioball already submitted a fix for it in apple/pkl-project-commons@c4a2007.

I'll update the PR with the new version of the dependency once it's released

@sitaktif sitaktif force-pushed the test-report-regexp-field branch from 2923b6b to 53022e7 Compare November 25, 2025 09:23
@sitaktif sitaktif marked this pull request as ready for review November 25, 2025 09:41
@sitaktif sitaktif force-pushed the test-report-regexp-field branch from 53022e7 to 65a23f8 Compare November 25, 2025 09:42
@KushalP
Copy link
Copy Markdown
Contributor

KushalP commented Nov 25, 2025

Something that would be useful to put back in place, is that previously we let Bazel own (and test) whether the .yml files were up-to-date: https://github.com/apple/rules_pkl/pull/121/files#diff-5cf10aebde4cdf51401459bd8df7f6b9876774779eb8b4f3846ac68ecc941cbbL28

It would be great to get that added back in

@sitaktif sitaktif merged commit 55078fc into apple:main Nov 25, 2025
4 checks passed
@sitaktif sitaktif deleted the test-report-regexp-field branch November 25, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants