Merged
Conversation
HT154
approved these changes
Dec 11, 2025
bioball
force-pushed
the
bump-ghactions
branch
from
4615eef to
a79eb5e
Compare
bioball
force-pushed
the
bump-ghactions
branch
from
1fc1bda to
d9f6dc0
Compare
bioball
commented
Dec 11, 2025
| # TODO need to provide "PWD" as an env var | ||
| # env = { | ||
| # "PWD": ".", | ||
| # }, |
Member
Author
There was a problem hiding this comment.
@KushalP FYI: I've disabled the bazel side of things here.
With the new version of pkl.impl.ghactions, we need to pass the PWD to Pkl so that it can read the existing lockfile (see https://github.com/apple/rules_pkl/pull/142/files#diff-2d8c57efa466feee81dd1a2e97d11a3593578baf10328e6a2616227fe068671d).
However, it looks like we're missing the ability to set env vars in pkl_eval right now.
bioball
force-pushed
the
bump-ghactions
branch
from
591a8c5 to
a04738c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.