Add all PKL libraies to pkl-config-java-internal#153
Merged
KushalP merged 5 commits intoapple:mainfrom Feb 24, 2026
Merged
Conversation
With the update of `rules_java` to `8.12.x` or later, the java compiler now complains about missing transitive dependencies more assertively. This affect the `pkl_java_library` rule when compiling `*.pkl` source code which uses the PKL core library functions. Trying to manually add these causes other problems. So add all of the PKL java libraies as dependecies to the `pkl_java_library` deps list. Update a test as well to demonstrate and show the resolution to the problem. revert two unneeded changes.
Contributor
Author
|
addresses #152 |
Contributor
|
Should we now declare |
KushalP
reviewed
Feb 20, 2026
| Animals.Dog dog2 = (Animals.Dog) animals.get(2); | ||
| assertEquals("Max", dog2.getName()); | ||
| assertEquals("German Shepherd", dog2.getBreed()); | ||
| assertEquals("Dog {\n name = Max\n age = 30.d\n breed = German Shepherd\n}", dog2.toString()); |
Contributor
There was a problem hiding this comment.
Minor: a future-friendly test here is probably to directly test the getAge() accessor, as the lines above do. As we're validating the Duration gets correctly exported.
…itive dependencies.
KushalP
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update of
rules_javato8.12.xor later, the java compiler now complains about missing transitive dependencies more assertively.This affect the
pkl_java_libraryrule when compiling*.pklsource code which uses the PKL core library functions. Trying to manually add these causes other problems. So add all of the PKL java libraies as dependecies to thepkl_java_librarydeps list.Update a test as well to demonstrate and show the resolution to the problem.
revert two unneeded changes.