Fix AsyncContext visibility for OTEL filters
#3219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `AbstractOpenTelemetryFilter` manually subscribes to response and its payload body but does not share context on subscribe. In result, `AsyncContext` propagation is incorrect when OTEL filters are in place. Modifications: - Add `shareContextOnSubscribe()` before subscribing response single and its payload Publisher. - Add a test that uses our utility to verify correct AsyncContext propagation. Result: `AsyncContext` state is correctly propagated through stages of response processing when OTEL filters are in place.
idelpivnitskiy
commented
Mar 28, 2025
|
|
||
| @Test | ||
| void verifyAsyncContextVisibility() throws Exception { | ||
| verifyServerFilterAsyncContextVisibility(new OpenTelemetryHttpServerFilter()); |
Member
Author
There was a problem hiding this comment.
@bryce-anderson I found the utility I was describing to you the other day and decided to submit a PR to demonstrate how to use it. We only have it for the server-side for now. It helps assert that filter in question does not break AsyncContext propagation.
bryce-anderson
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
AbstractOpenTelemetryFiltermanually subscribes to response and its payload body but does not share context on subscribe. In result,AsyncContextpropagation is incorrect when OTEL filters are in place.Modifications:
shareContextOnSubscribe()before subscribing response single and its payload Publisher.Result:
AsyncContextstate is correctly propagated through stages of response processing when OTEL filters are in place.