Backport CMake support to 3.15.1 #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sure, that’s reasonable. From the CMake perspective, it seems fine. Just adds a bit of complexity, so as long as Nate’s happy, LGTM. |
Member
|
@owenv Looks good on my end, just let me know when you’ve been able to verify on Windows. Thanks! 🙏 |
Collaborator
|
@natecook1000 https://dev.azure.com/compnerd/swift-build/_build/results?buildId=33747&view=results Lets just make it easy - triggered a CI run for argument-parser :) |
Collaborator
|
Seems to build fine on Windows :) |
Member
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the SPM builders appear to be running CMake 3.15.4, so I'm back porting ArgumentParser to 3.15.1 to match SPM's minimum version. I haven't tested this on Windows yet to make sure the output directory workarounds behave as expected, I'm going to try to spin up a VM this weekend.
Checklist
cc @compnerd