Skip to content

Conversation

@3405691582
Copy link
Contributor

@3405691582 3405691582 commented Mar 17, 2021

On this platform, the TIOCGWINSZ ioctl identifier is a complex macro.
Since we don't have a C bridging header obviously available to get the
flattened value, supply is the flattened value obtained elsewhere. This
is of course brittle but this is the simplest way around this for now.

Additionally, ensure we support the platform architecture name, where
the x86_64 architecture is called amd64 instead.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
    • not trivially testable
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary
    • not covered

On this platform, the TIOCGWINSZ ioctl identifier is a complex macro.
Since we don't have a C bridging header obviously available to get the
flattened value, supply is the flattened value obtained elsewhere. This
is of course brittle but this is the simplest way around this for now.

Additionally, ensure we support the platform architecture name, where
the x86_64 architecture is called amd64 instead.
@natecook1000
Copy link
Member

Thanks for this, @3405691582!

@natecook1000
Copy link
Member

@swift-ci Please test

@3405691582
Copy link
Contributor Author

Linux test failed for timeout. Maybe transient, could you restart?

@kylemacomber
Copy link

@swift-ci please test

@natecook1000 natecook1000 merged commit b936799 into apple:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants